Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add forwarder_iam_path variable to allow for iam role and policy paths #31

Merged
merged 4 commits into from Mar 21, 2022
Merged

Conversation

ebram-va
Copy link
Contributor

what

  • This feature allows a path to be passed into the module when creating aws_iam_role and aws_iam_policy.

why

  • Some company policies have boundary conditions in place that only allow aws_iam_role and aws_iam_policy to be created with a specific naming convention, which includes paths. A name does not allow characters such as forward slashes which may be necessary.

references

  • N/A

@ebram-va ebram-va requested review from a team as code owners March 17, 2022 19:58
@jamengual
Copy link
Contributor

could you run terraform fmt?

@jamengual
Copy link
Contributor

/test all

@ebram-va
Copy link
Contributor Author

@jamengual it looks like the Auto Format job ran a terraform fmt against it and committed before I could. I did however look through the logs and saw an issue where the default path as empty string would fail so I updated that.

@jamengual
Copy link
Contributor

/test all

@korenyoni korenyoni added the enhancement New feature or request label Mar 21, 2022
Copy link
Contributor

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for the contribution!

@jamengual jamengual merged commit e7cbc67 into cloudposse:master Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants