fix: propagate preferred_maintenance_window to the docdb cluster instances resources

[sherifkayad]

propagated preferred_maintenance_window to the docdb cluster instances resources

what

• The maintenance window given as a variable is given to the Terraform Resource aws_docdb_cluster_instance.default such that the cluster and its instances have the same value given by the user
• Closes preferred_maintenance_window from the variables isn't propagated to the docdb_cluster_instance resources #55

why

• Without that the cluster instances were having "random" windows that don't match the expectations of "potential" down time
• Users want to be in control of when their databases can go under maintenance not just at any "random" time

references

• https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/docdb_cluster_instance#preferred_maintenance_window

[sherifkayad]

@maintainers,

is there like a known issue with the Github workflow? .. Seems like the workflow wants to push something to my forked repo and it fails ..

[aknysh]

@sherifkayad thanks for the PR

Please run the following commands and commit the changes:

make init
make github/init
make readme

[aknysh]

/test all

[aknysh]

please see comments

[max-lobur]

@maintainers,

is there like a known issue with the Github workflow? .. Seems like the workflow wants to push something to my forked repo and it fails ..

I have rolled out the updated workflows to this repo, please rebase on main, run

make init
make readme

and it should all be green 👍

[sherifkayad]

@aknysh @max-lobur thanks for your comments. I rebased, ran the required commands and pushed again. Could you please have another look?

[aknysh]

/test all

[sherifkayad]

@aknysh is that something I can fix? .. Didn't quite get why the linting is failing

[sherifkayad]

after another check, seems like the linter is failing on all 17 occurences of join("", aws_SOMETHING.NAME.*.PROPERTY). I can happily push a fix that would make tflint happy

[aknysh]

after another check, seems like the linter is failing on all 17 occurences of join("", aws_SOMETHING.NAME.*.PROPERTY). I can happily push a fix that would make tflint happy

@sherifkayad yes, this is the issue, thank you

[aknysh]

/test all

[max-lobur]

/terratest