Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable intra-security group traffic on DB port #61

Merged
merged 4 commits into from May 24, 2023
Merged

Enable intra-security group traffic on DB port #61

merged 4 commits into from May 24, 2023

Conversation

kevcube
Copy link
Sponsor Contributor

@kevcube kevcube commented May 22, 2023

what

  • adds variable allow_ingress_from_self which configures the security group to allow traffic within itself on DB port

why

  • This is useful in architectures where the db security group will be used to control db access - i.e. it will also be applied to applications.

references

cloudposse/terraform-aws-rds-cluster#145

@kevcube kevcube requested review from a team as code owners May 22, 2023 06:55
@kevcube kevcube requested review from Gowiem and joe-niland May 22, 2023 06:55
@Benbentwo
Copy link
Member

Benbentwo commented May 23, 2023 •
edited

hey @kevcube, thanks for the PR!

Can you please update the readme with

make init
make readme

This should happen automatically, but that will let this be merged in faster

@max-lobur
Copy link
Contributor

Try make precommit/terraform - it should fix both format and the readme

@kevcube
Copy link
Sponsor Contributor Author

kevcube commented May 24, 2023

@Benbentwo @max-lobur done

@max-lobur
Copy link
Contributor

/terratest

@max-lobur max-lobur enabled auto-merge (squash) May 24, 2023 17:31
@max-lobur max-lobur merged commit cab714a into cloudposse:main May 24, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-lobur max-lobur max-lobur approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevcube @Benbentwo @max-lobur