Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable ipv6 #147

Closed
wants to merge 3 commits into from
Closed

Conversation

dnsinogeorgos
Copy link

what

  • Allows deployment of IPv6 enabled subnets
  • Does not break existing deployments

why

  • Need for IPv6 in modern environments

Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found infrastructure configuration errors in this PR ⬇️

@@ -29,7 +29,13 @@ resource "aws_subnet" "public" {
local.public_subnet_count + count.index
)

map_public_ip_on_launch = var.map_public_ip_on_launch
ipv6_cidr_block = var.public_subnets_associate_ipv6_cidr ? cidrsubnet(
Copy link

@bridgecrew bridgecrew bot Jan 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MEDIUM   Ensure VPC subnets do not assign public IP by default
    Resource: aws_subnet.public | ID: BC_AWS_NETWORKING_53
Error in referred variable: variable "map_public_ip_on_launch"

How to Fix

resource "aws_subnet" "test" {
 ...
+ map_public_ip_on_launch = false
  }

Description

VPC subnet is a part of the VPC having its own rules for traffic. Assigning the Public IP to the subnet automatically (on launch) can accidentally expose the instances within this subnet to internet and should be edited to 'No' post creation of the Subnet.

@marekmoscichowski marekmoscichowski mentioned this pull request Jan 25, 2022
@Nuru Nuru closed this in #159 May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant