Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regressions #59

Merged
merged 2 commits into from
Jun 20, 2019
Merged

Fix regressions #59

merged 2 commits into from
Jun 20, 2019

Conversation

osterman
Copy link
Member

@osterman osterman commented Jun 20, 2019 •
edited
Loading

what

why

  • Instead, pass providers which is a built-in concept of terraform
  • Providers accept more than region
  • We were not able to test PR in codefresh for the external contributor

@osterman osterman requested a review from aknysh June 20, 2019 19:09
@osterman osterman changed the title fix regressions Fix regressions Jun 20, 2019
@osterman osterman merged commit 13c0c1d into master Jun 20, 2019
@osterman osterman deleted the fix-tests branch June 20, 2019 19:31
aknysh added a commit that referenced this pull request Jun 21, 2019
@aknysh
Revert "Fix regressions (#59)"
db382ff 
This reverts commit 13c0c1d.
aknysh added a commit that referenced this pull request Jun 21, 2019
@aknysh
Revert "Fix regressions (#59)"
b2cc150 
This reverts commit 13c0c1d.
@aknysh aknysh mentioned this pull request Jun 21, 2019
Merged
aknysh added a commit that referenced this pull request Jun 21, 2019
@aknysh
Revert "Fix regressions (#59)" (#61)
8f9f137 
This reverts commit 13c0c1d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@osterman @aknysh