Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set read/write capacity in PAY_PER_REQUEST billing mode #101

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

alexjurkiewicz
Copy link
Contributor

This causes errors at plan-time now:

Error: 2 errors occurred:
	* read_capacity can not be set when billing_mode is "PAY_PER_REQUEST"
	* write_capacity can not be set when billing_mode is "PAY_PER_REQUEST"

  with module.dynamodb_table.aws_dynamodb_table.default[0],
  on .terraform/modules/dynamodb_table/main.tf line 46, in resource "aws_dynamodb_table" "default":
  46: resource "aws_dynamodb_table" "default" {

@alexjurkiewicz alexjurkiewicz requested review from a team as code owners January 25, 2022 09:27
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found infrastructure configuration errors in this PR ⬇️

main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
Gowiem
Gowiem previously approved these changes Jan 25, 2022
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy -- Thanks as always @alexjurkiewicz 👍

@Gowiem
Copy link
Member

Gowiem commented Jan 25, 2022

/test all

@Gowiem
Copy link
Member

Gowiem commented Jan 25, 2022

@alexjurkiewicz our validate check got stuck. Mind pushing an empty commit to try and trigger it again?

This causes errors at plan-time now:

Error: 2 errors occurred:
	* read_capacity can not be set when billing_mode is "PAY_PER_REQUEST"
	* write_capacity can not be set when billing_mode is "PAY_PER_REQUEST"

  with module.dynamodb_table.aws_dynamodb_table.default[0],
  on .terraform/modules/dynamodb_table/main.tf line 46, in resource "aws_dynamodb_table" "default":
  46: resource "aws_dynamodb_table" "default" {
main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️   Due to a3597eb - Don't set read/write capacity in PAY_PER_REQUEST billing mode - 2 new errors were added

Change details

Error ID Change Path Resource
BC_AWS_GENERAL_52 Added /main.tf aws_dynamodb_table.default
BC_AWS_GENERAL_44 Added /main.tf aws_dynamodb_table.default

@alexjurkiewicz
Copy link
Contributor Author

alexjurkiewicz commented Jan 26, 2022 via email

main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️   Due to 1f2a0c9 - Auto Format - 2 new errors were added

Change details

Error ID Change Path Resource
BC_AWS_GENERAL_52 Added /main.tf aws_dynamodb_table.default
BC_AWS_GENERAL_44 Added /main.tf aws_dynamodb_table.default

@Gowiem
Copy link
Member

Gowiem commented Jan 26, 2022

/test all

@Gowiem Gowiem added the patch A minor, backward compatible change label Jan 26, 2022
@Gowiem Gowiem merged commit 322c4dc into cloudposse:master Jan 26, 2022
@alexjurkiewicz alexjurkiewicz deleted the pay-per-request branch January 27, 2022 22:16
@alexjurkiewicz
Copy link
Contributor Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch A minor, backward compatible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants