Issue 110: Add enable deletion protection #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why is this issue/feature still open since Mai 10 2023? will it ever be implemented in the module? |
|
/terratest |
joe-niland
approved these changes
Aug 26, 2023
|
Thanks for your contribution @ignacioSuay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add deletion_protection_enabled to the module. This feature is already available in terraform resource.
why
Terraform dynamodb_table resource has the optional parameter:
deletion_protection_enabled - (Optional) Enables deletion protection for table. Defaults to false.
We would like to be able to use the flag to avoid accidentally deleting DynamoDB tables. Therefore, we would like to add an extra variable to the module to enable/disable deletion protection.
references
This PR is related to the issue raise by the community:
#110