Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set desired_capacity in aws_autoscaling_group as optional #67

Merged
merged 1 commit into from
May 9, 2021
Merged

set desired_capacity in aws_autoscaling_group as optional #67

merged 1 commit into from
May 9, 2021

Conversation

ByJacob
Copy link
Contributor

@ByJacob ByJacob commented May 6, 2021 •
edited by Nuru

what

  • set desired_capacity in aws_autoscaling_group as optional

why

  • When auto-scaling is set to 2 and updating asg, the number of instances drops to the minimum value

references

@ByJacob ByJacob requested review from a team as code owners May 6, 2021 09:01
@ByJacob ByJacob requested review from dotCipher and 3h4x May 6, 2021 09:01
@ByJacob
Copy link
Contributor Author

ByJacob commented May 6, 2021

/test all

1 similar comment
@Nuru
Copy link
Sponsor Contributor

Nuru commented May 8, 2021

/test all

@Nuru Nuru merged commit eb3a2ba into cloudposse:master May 9, 2021
@Nuru Nuru mentioned this pull request May 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@dotCipher dotCipher Awaiting requested review from dotCipher

@3h4x 3h4x Awaiting requested review from 3h4x

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

desired_capacity should be optional
2 participants
@ByJacob @Nuru