Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

* add throughput to block_device_mapping #97

Merged
merged 4 commits into from
Oct 26, 2023
Merged

* add throughput to block_device_mapping #97

merged 4 commits into from
Oct 26, 2023

Conversation

zaksamalik
Copy link
Contributor

what

  • add throughput to block_device_mapping

why

  • allows throughput configuration for block device mappings

references

@zaksamalik zaksamalik requested review from a team as code owners November 28, 2022 20:47
@zaksamalik zaksamalik mentioned this pull request Nov 28, 2022
Closed
@joe-niland
Copy link
Sponsor Member

/test all

@joe-niland
Copy link
Sponsor Member

/test all

@joe-niland
Copy link
Sponsor Member

/rebuild-readme

1 similar comment
@jamengual
Copy link
Contributor

/rebuild-readme

@y3ti
Copy link

y3ti commented Oct 6, 2023

Any plans to merge it?

@Gowiem
Copy link
Member

Gowiem commented Oct 25, 2023

@zaksamalik can you pull in the main branch and deal with any conflicts + please run the following commands, commit, and push the changes:

make init
make github/init
make readme

@zaksamalik
Copy link
Contributor Author

@zaksamalik can you pull in the main branch and deal with any conflicts + please run the following commands, commit, and push the changes:

make init
make github/init
make readme

@Gowiem PR should be ready to go. Please lmk if I missed anything and I will update, thanks.

@Gowiem Gowiem added the minor New features that do not break anything label Oct 26, 2023
@Gowiem
Copy link
Member

Gowiem commented Oct 26, 2023

/terratest

@Gowiem Gowiem enabled auto-merge (squash) October 26, 2023 17:37
@Gowiem
Copy link
Member

Gowiem commented Oct 26, 2023

@zaksamalik this requires another approval from someone internal at Cloud Posse. I've requested that in Slack and we'll get this merged shortly. Thanks for the patience!

@Gowiem Gowiem merged commit b757eb9 into cloudposse:main Oct 26, 2023
17 checks passed
@MaxymVlasov MaxymVlasov mentioned this pull request Nov 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@aknysh aknysh aknysh approved these changes

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland is a code owner automatically assigned from cloudposse/contributors

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
minor New features that do not break anything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing throughput in block_device_mappings.
6 participants
@zaksamalik @joe-niland @jamengual @y3ti @Gowiem @aknysh