Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add self service portal #35

Merged
merged 10 commits into from
Mar 10, 2022
Merged

Add self service portal #35

merged 10 commits into from
Mar 10, 2022

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Mar 9, 2022 •
edited by Nuru
Loading

what

  • Add self service portal
  • Update tests to current standard for go 1.17
  • Update workflows

why

  • Allow users to customize the portal when connecting to the client vpn
  • Routine maintenance

references

module "client_vpn" {
  source = "git::https://github.com/cloudposse/terraform-aws-ec2-client-vpn.git?ref=portal"

  # ...
}

@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode marked this pull request as ready for review March 9, 2022 02:27
@nitrocode nitrocode requested review from a team as code owners March 9, 2022 02:27
r351574nc3
r351574nc3 previously approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@r351574nc3 r351574nc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Nuru
Copy link
Sponsor Contributor

Nuru commented Mar 10, 2022

/test all

@Nuru
Copy link
Sponsor Contributor

Nuru commented Mar 10, 2022

/test all

@Nuru
Copy link
Sponsor Contributor

Nuru commented Mar 10, 2022

/test all

@Nuru Nuru self-requested a review March 10, 2022 02:38
Nuru
Nuru previously approved these changes Mar 10, 2022
View reviewed changes
@Nuru
Copy link
Sponsor Contributor

Nuru commented Mar 10, 2022

/test all

@Nuru
Copy link
Sponsor Contributor

Nuru commented Mar 10, 2022

/test terratest
previous test failed with a timeout

@Nuru Nuru self-requested a review March 10, 2022 03:26
@Nuru Nuru merged commit 2adcce8 into master Mar 10, 2022
@Nuru Nuru deleted the portal branch March 10, 2022 03:28
@Nuru Nuru mentioned this pull request Mar 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@r351574nc3 r351574nc3 r351574nc3 left review comments

@joe-niland joe-niland Awaiting requested review from joe-niland joe-niland was automatically assigned from cloudposse/contributors

@dylanbannon dylanbannon Awaiting requested review from dylanbannon dylanbannon was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

self_service_portal
4 participants
@nitrocode @Nuru @r351574nc3 @cloudpossebot