Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags for EIPs #189

Closed
viliampucik opened this issue Mar 27, 2024 · 1 comment · Fixed by #190
Closed

Tags for EIPs #189

viliampucik opened this issue Mar 27, 2024 · 1 comment · Fixed by #190

Comments

@viliampucik
Copy link

Describe the Feature

After changing additional_ips_count from 0 to 1, the newly created secondary EIP does not inherit tags from the pre-existing EC2 instance. Can tags be enabled explicitly for EIPs by the module?

Expected Behavior

All EIPs are properly tagged.

Use Case

I've created a new EC2 instance with public EIP using the module. After some time I had to add another public static IP to the EC2, so I've increased additional_ips_count from 0 to 1. The additional EIP was created, but without any tags.

Describe Ideal Solution

All EIPs have tags automatically assigned to them either explicitly by the module or by AWS.

Alternatives Considered

Adding default_tags {} section into AWS provider block adds tags to EIP, but also to other resources. In case of EC2's EBS, it tried to add the same tags each terraform apply, which was inconvenient.

Additional Context

No response

@bwmetcalf
Copy link
Contributor

@viliampucik #190

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants