fix: cleans up principals lambda logic to separate policy doc #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
/terratest |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
/terratest |
|
/terratest |
aknysh
reviewed
May 24, 2023
main.tf
Outdated
| } | ||
|
|
||
| data "aws_iam_policy_document" "lambda_access" { | ||
| count = module.this.enabled ? 1 : 0 |
There was a problem hiding this comment.
if var.principals_lambda is empty, do we need to create this aws_iam_policy_document at all?
condition.values will be an empty list
There was a problem hiding this comment.
@aknysh yeah, this is how the other policy docs are built, so I was just staying with the pattern that is already established + decrease the risk of breaking something. Think we should rework?
There was a problem hiding this comment.
let's have it as it was before.
We can update it in a separate PR
aknysh
approved these changes
May 25, 2023
aknysh
reviewed
May 25, 2023
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
|
/terratest |
aknysh
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
var.principals_lambdapolicieswhy
references