New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only create the sg if network_mode == awsvpc #107

Merged

jamengual merged 1 commit into master from create-sg-if-awsvpc

Feb 25, 2021

Member

nitrocode commented Feb 24, 2021 •

edited

what

Only create the sg if network_mode == awsvpc

why

Looks like the security group is used only if var.network_mode = "awsvpc"

references

Only create aws_security_group if var.network_mode = "awsvpc" #102
May also address Use name_prefix and create_before_destroy on security groups #77 if the sg is not needed in that use case


          Only create the sg if network_mode == awsvpc

fadca59

nitrocode requested review from a team as code owners

February 24, 2021 23:29

Member Author

nitrocode commented Feb 24, 2021

/test all

1 similar comment

Member Author

nitrocode commented Feb 24, 2021

/test all

jamengual approved these changes

View reviewed changes

jamengual merged commit a0ed5cd into master

jamengual deleted the create-sg-if-awsvpc branch

February 25, 2021 00:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment