Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use security-group module instead of resource #117

Merged
merged 3 commits into from
Jun 15, 2021
Merged

feat: use security-group module instead of resource #117

merged 3 commits into from
Jun 15, 2021

Conversation

SweetOps
Copy link
Contributor

what

  • use security-group module instead of resource
  • update tests

why

  • more flexible than current implementation
  • bring configuration of security group/rules to one standard

references

  • CPCO-409

@SweetOps
Copy link
Contributor Author

/test all

@SweetOps
Copy link
Contributor Author

/test all

@SweetOps
Copy link
Contributor Author

/test all

@SweetOps SweetOps marked this pull request as ready for review May 27, 2021 16:39
@SweetOps SweetOps requested review from a team as code owners May 27, 2021 16:39
@SweetOps SweetOps requested review from Gowiem and adamcrews and removed request for a team May 27, 2021 16:39
@nitrocode nitrocode merged commit 4988650 into master Jun 15, 2021
@nitrocode nitrocode deleted the CPCO-409 branch June 15, 2021 18:42
@ento ento mentioned this pull request Jul 13, 2021
Closed
inhumantsar pushed a commit to inhumantsar/terraform-aws-ecs-alb-service-task that referenced this pull request Aug 10, 2021
@SweetOps @inhumantsar
feat: use security-group module instead of resource (cloudposse#117)
ed4c1e6 
* feat: use security-group module instead of resource
nitrocode added a commit that referenced this pull request Aug 24, 2021
@nitrocode
Revert "feat: use security-group module instead of resource (#117)"
f81e3a2 
This reverts commit 4988650.
Nuru added a commit that referenced this pull request Dec 27, 2021
@Nuru
Revert "feat: use security-group module instead of resource (#117)"
fcde887 
This reverts commit 4988650.
@Nuru Nuru mentioned this pull request Dec 27, 2021
Merged
Nuru added a commit that referenced this pull request Dec 27, 2021
@Nuru
Restore release cadence (#155)
5777ca3 
* Revert "feat: use security-group module instead of resource (#117)"

This reverts commit 4988650.

* Implement deferred maintenance
mfroembgen pushed a commit to justtrackio/terraform-aws-ecs-alb-service-task that referenced this pull request Jan 18, 2023
@semantic-release-bot
chore(release): version 1.0.0 [skip ci]
2b2de92 
## 1.0.0 (2023-01-18)

### Features

* add configurable runtime ([cloudposse#151](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/151)) ([dba1474](dba1474))
* add deployment_controller option ([cloudposse#28](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/28)) ([efa167c](efa167c))
* add force_new_deployment variable ([cloudposse#112](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/112)) ([53c693c](53c693c))
* Add more configuration options from aws provider ([cloudposse#37](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/37)) ([b3ee30b](b3ee30b))
* add new label for ecs ([#1](#1)) ([49a2eec](49a2eec))
* Add optional "propagate_tags" variable ([cloudposse#32](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/32)) ([abf388a](abf388a))
* adds ephemeral_storage_size var for Fargate ([cloudposse#158](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/158)) ([a3d3037](a3d3037))
* Allow configuration of auto assign public IP ([cloudposse#24](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/24)) ([d8b29c7](d8b29c7))
* **aws_ecs_service:** Add support for "capacity_provider_strategy" ([cloudposse#43](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/43)) ([0384fca](0384fca))
* grant ssm:GetParameters to ecs_exec role ([cloudposse#42](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/42)) ([e053720](e053720))
* use security-group module instead of resource ([cloudposse#117](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/117)) ([4988650](4988650))
ztzxt pushed a commit to justtrackio/terraform-aws-ecs-alb-service-task that referenced this pull request Apr 11, 2024
@semantic-release-bot @ztzxt
chore(release): version 1.0.0 [skip ci]
825dc4b 
## 1.0.0 (2023-01-18)

### Features

* add configurable runtime ([cloudposse#151](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/151)) ([dba1474](dba1474))
* add deployment_controller option ([cloudposse#28](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/28)) ([efa167c](efa167c))
* add force_new_deployment variable ([cloudposse#112](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/112)) ([53c693c](53c693c))
* Add more configuration options from aws provider ([cloudposse#37](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/37)) ([b3ee30b](b3ee30b))
* add new label for ecs ([#1](#1)) ([49a2eec](49a2eec))
* Add optional "propagate_tags" variable ([cloudposse#32](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/32)) ([abf388a](abf388a))
* adds ephemeral_storage_size var for Fargate ([cloudposse#158](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/158)) ([a3d3037](a3d3037))
* Allow configuration of auto assign public IP ([cloudposse#24](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/24)) ([d8b29c7](d8b29c7))
* **aws_ecs_service:** Add support for "capacity_provider_strategy" ([cloudposse#43](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/43)) ([0384fca](0384fca))
* grant ssm:GetParameters to ecs_exec role ([cloudposse#42](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/42)) ([e053720](e053720))
* use security-group module instead of resource ([cloudposse#117](https://github.com/justtrackio/terraform-aws-ecs-alb-service-task/issues/117)) ([4988650](4988650))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem

@adamcrews adamcrews Awaiting requested review from adamcrews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SweetOps @nitrocode