Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated with deployment circuit breaker #120

Merged
merged 5 commits into from
Jul 7, 2021
Merged

Updated with deployment circuit breaker #120

merged 5 commits into from
Jul 7, 2021

Conversation

flywheelnz
Copy link
Contributor

what

  • Updated to support deployment circuit breaker and optional rollback

why

  • AWS feature compatability

@flywheelnz flywheelnz requested review from a team as code owners June 17, 2021 23:57
@flywheelnz flywheelnz requested review from Gowiem and brcnblc and removed request for a team June 17, 2021 23:57
joe-niland
joe-niland previously requested changes Jun 18, 2021
View reviewed changes
Copy link
Sponsor Member

@joe-niland joe-niland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @flywheelnz, just some minor things

variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@joe-niland
Copy link
Sponsor Member

@flywheelnz please allow maintainer edits on your PR so the automated formatting, etc can run

@flywheelnz flywheelnz marked this pull request as draft June 18, 2021 02:38
@mergify mergify bot dismissed joe-niland’s stale review June 18, 2021 04:22

This Pull Request has been updated, so we're dismissing all reviews.

@flywheelnz
Copy link
Contributor Author

@joe-niland Not sure we can add maintainer edits to an organisation repository, so I've added cloudpossebot manually - let me know if there's any issues.

@flywheelnz flywheelnz marked this pull request as ready for review June 18, 2021 04:26
@joe-niland
Copy link
Sponsor Member

/test all

@joe-niland
Copy link
Sponsor Member

@flywheelnz you're right. unfortunately this didn't allow access to Github Actions. Possible to resubmit from an individual account?

@flywheelnz
Copy link
Contributor Author

@joe-niland Fixed!

@flywheelnz flywheelnz marked this pull request as draft June 22, 2021 04:57
@flywheelnz flywheelnz marked this pull request as ready for review June 22, 2021 04:58
@joe-niland
Copy link
Sponsor Member

/test all

1 similar comment
@joe-niland
Copy link
Sponsor Member

/test all

@joe-niland
Copy link
Sponsor Member

/rebuild-readme

@joe-niland
Copy link
Sponsor Member

/test readme

@joe-niland
Copy link
Sponsor Member

/test bats

@joe-niland
Copy link
Sponsor Member

@flywheelnz thanks - getting somewhere now! I think maybe a find-replace renamed the block name. Please have a look. Also if you can try running make pr/auto-format locally it may resolve some other issues.

@flywheelnz flywheelnz marked this pull request as draft July 6, 2021 22:04
@flywheelnz
Copy link
Contributor Author

Sorry for the delay on this - we're sure busy at the moment.
Fixed the accidental block replacement. Ran make pr/auto-format

@flywheelnz flywheelnz marked this pull request as ready for review July 6, 2021 22:06
@joe-niland
Copy link
Sponsor Member

/test all

@joe-niland joe-niland merged commit 851ae54 into cloudposse:master Jul 7, 2021
joe-niland pushed a commit that referenced this pull request Jul 7, 2021
@flywheelnz @actions-bot @joe-niland
Updated with deployment circuit breaker (#120)
b7d17c5 
* Updated with deployment circuit breaker

* Renamed variables for consistency

* Updated README.md

* Fix accidentally renamed block.
Formatted and generated README

Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
@joe-niland joe-niland mentioned this pull request Jul 7, 2021
Closed
@joe-niland
Copy link
Sponsor Member

Thanks @flywheelnz busy is good! :)
This has been released. Just FYI, some upcoming module refactoring (see release 0.57.0) will possibly remove release 0.58.0, so you may need to adjust the version in your TF code. Will try to notify you.

ByJacob pushed a commit to ByJacob/terraform-aws-ecs-alb-service-task that referenced this pull request Jul 8, 2021
@flywheelnz @actions-bot
Updated with deployment circuit breaker (cloudposse#120)
aa164bd 
* Updated with deployment circuit breaker

* Renamed variables for consistency

* Updated README.md

* Fix accidentally renamed block.
Formatted and generated README

Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
ento added a commit to StriveTalent/terraform-aws-ecs-alb-service-task that referenced this pull request Jul 13, 2021
@ento
Delete symlink that's likely not needed
806ff24 
Added in cloudposse#120 but other module repos of cloudposse don't seem to
have a symlink like this.
inhumantsar pushed a commit to inhumantsar/terraform-aws-ecs-alb-service-task that referenced this pull request Aug 10, 2021
@flywheelnz @actions-bot @inhumantsar
Updated with deployment circuit breaker (cloudposse#120)
7ed19a4 
* Updated with deployment circuit breaker

* Renamed variables for consistency

* Updated README.md

* Fix accidentally renamed block.
Formatted and generated README

Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
inhumantsar added a commit to inhumantsar/terraform-aws-ecs-alb-service-task that referenced this pull request Aug 10, 2021
@inhumantsar
Revert "Updated with deployment circuit breaker (cloudposse#120)"
47c10a4 
This reverts commit 7ed19a4.
nitrocode added a commit that referenced this pull request Aug 24, 2021
@nitrocode
Revert "Updated with deployment circuit breaker (#120)"
cf2a6b5 
This reverts commit 851ae54.
Nuru added a commit that referenced this pull request Dec 27, 2021
@Nuru
Revert "Updated with deployment circuit breaker (#120)"
c9c07ee 
This reverts commit 851ae54.
@Nuru Nuru mentioned this pull request Dec 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-niland joe-niland joe-niland approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem

@brcnblc brcnblc Awaiting requested review from brcnblc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flywheelnz @joe-niland @actions-bot