Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task exec role arn #63

Merged
merged 3 commits into from
Jul 13, 2020
Merged

Task exec role arn #63

merged 3 commits into from
Jul 13, 2020

Conversation

ac-hibbert
Copy link
Contributor

@ac-hibbert ac-hibbert commented Jul 10, 2020 •
edited

what

  • Add ability to override the task execution role arn as opposed to the module creating a default role

why

  • The user may want to create the role outside of this module as the IAM profile may not fit their needs. For example using secretsmanager instead of ssm or wanting to restrict the container to specific secrets.

references

Andy Hibbert added 2 commits July 10, 2020 19:06
task_exec_role_arn: Allow override of task execution role
c63e389 
Change-Id: I69b13345533c5d9ae0eefac9c78a88638e5ee93f
task_exec_role_arn: Change variable description
66c8123 
Change-Id: Ie320d967b170b31e34af88c5210fd2c85659e9dd
@nitrocode
Copy link
Member

/rebuild-readme

@nitrocode
Copy link
Member

/terraform-fmt

@nitrocode
Copy link
Member

/test all

@nitrocode nitrocode closed this Jul 12, 2020
@nitrocode nitrocode reopened this Jul 12, 2020
@osterman osterman merged commit 42ea67f into cloudposse:master Jul 13, 2020
@ac-hibbert ac-hibbert mentioned this pull request Jul 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass in an AWS execution role instead of creating our own
4 participants
@ac-hibbert @nitrocode @osterman @actions-bot