Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add task_exec and task role policy attachments #84

Merged
merged 3 commits into from Dec 21, 2020
Merged

Add task_exec and task role policy attachments #84

merged 3 commits into from Dec 21, 2020

Conversation

sodre
Copy link
Contributor

@sodre sodre commented Dec 20, 2020 •
edited by Nuru

what

  • Creates two variables to accept a list of policies to attach to the generated task and task execution roles
  • The policies are only attached if the the roles were created by this module.

why

  • When creating services that reference outside secrets it would be easier to pass the required policy during service creation.

references

@sodre sodre requested a review from a team as a code owner December 20, 2020 02:33
@sodre sodre requested review from Makeshift and joe-niland and removed request for a team December 20, 2020 02:33
@joe-niland
Copy link
Sponsor Member

@sodre the title starts with WIP. Ready to review?

@sodre sodre changed the title WIP: Add task_exec and task role policy attachments Add task_exec and task role policy attachments Dec 20, 2020
@sodre
Copy link
Contributor Author

sodre commented Dec 20, 2020

@joe-niland, this should be read for review.

@Nuru
Copy link
Sponsor Contributor

Nuru commented Dec 21, 2020

/test all

@sodre @Nuru
Add task_exec and task role policy attachments
338a378 
  Creates two variables to accept a list of policies to attach to the generated task and task execution roles

  The policies are only attached if the the roles were created by this module.
@sodre sodre requested review from a team as code owners December 21, 2020 03:37
@Nuru
Copy link
Sponsor Contributor

Nuru commented Dec 21, 2020

/test all

@Nuru Nuru added the patch A minor, backward compatible change label Dec 21, 2020
@Nuru Nuru merged commit 40c29c9 into cloudposse:master Dec 21, 2020
@sodre sodre deleted the f/policy-attachment branch December 27, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nuru Nuru Nuru approved these changes

@Makeshift Makeshift Awaiting requested review from Makeshift

@joe-niland joe-niland Awaiting requested review from joe-niland

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sodre @joe-niland @Nuru @cloudpossebot