Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module modernisation #102

Merged
merged 3 commits into from
Nov 16, 2020

Conversation

joe-niland
Copy link
Sponsor Member

what

  • relax provider pinning
  • add chatops
  • add autorelease
  • use new terratest structure

why

  • Allow this module to be consumed by modules using later version of providers
  • Add gitops automation

references

- relax provider pinning
- add chatops
- add autorelease
- use new terratest structure
@joe-niland
Copy link
Sponsor Member Author

/test all

@joe-niland
Copy link
Sponsor Member Author

/test bats

@joe-niland
Copy link
Sponsor Member Author

/test terratest

@joe-niland
Copy link
Sponsor Member Author

/test readme

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @joe-niland, LGTM
Can you please update this as well https://github.com/joe-niland/terraform-aws-ecs-container-definition/blob/update-provider-pinning/examples/complete/versions.tf

Also, we are updating all out modules to context.tf, would be nice to do it in this PR instead of opening another one later.
We are basically adding context.tf files to the module and to the example (and removing some variables that are already present in context.tf).
Here is how to do it:

https://github.com/cloudposse/terraform-aws-service-control-policies/blob/master/context.tf

https://github.com/cloudposse/terraform-aws-service-control-policies/blob/master/examples/complete/main.tf#L7

https://github.com/cloudposse/terraform-aws-service-control-policies/blob/master/examples/complete/context.tf

thank you

@joe-niland
Copy link
Sponsor Member Author

Hi @aknysh

I'll fix the example - missed that!

Regarding context, I did look at that but I ended up removing it because:

  • the environment variable conflicts
  • there is no label module usage

Let me know if I should add. I can at least change var.environment to use module.this.environment

@jamengual
Copy link

/rebuild-readme

@jamengual
Copy link

/test all

@aknysh
Copy link
Member

aknysh commented Nov 16, 2020

Hi @aknysh

I'll fix the example - missed that!

Regarding context, I did look at that but I ended up removing it because:

  • the environment variable conflicts
  • there is no label module usage

Let me know if I should add. I can at least change var.environment to use module.this.environment

ah yes, this module is just a converter, no need for context.tf

@joe-niland joe-niland merged commit de06012 into cloudposse:master Nov 16, 2020
@joe-niland joe-niland deleted the update-provider-pinning branch November 16, 2020 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please update local provider requirement to 2.0.0 version
3 participants