-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module modernisation #102
Module modernisation #102
Conversation
/test all |
/test bats |
/test terratest |
/test readme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @joe-niland, LGTM
Can you please update this as well https://github.com/joe-niland/terraform-aws-ecs-container-definition/blob/update-provider-pinning/examples/complete/versions.tf
Also, we are updating all out modules to context.tf
, would be nice to do it in this PR instead of opening another one later.
We are basically adding context.tf
files to the module and to the example (and removing some variables that are already present in context.tf
).
Here is how to do it:
https://github.com/cloudposse/terraform-aws-service-control-policies/blob/master/context.tf
thank you
Hi @aknysh I'll fix the example - missed that! Regarding context, I did look at that but I ended up removing it because:
Let me know if I should add. I can at least change |
/rebuild-readme |
/test all |
ah yes, this module is just a converter, no need for |
what
why
references