Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add port mapping name (#162) #166

Merged
merged 3 commits into from Sep 26, 2023
Merged

fix: add port mapping name (#162) #166

merged 3 commits into from Sep 26, 2023

Conversation

aaronlake
Copy link
Contributor

what

  • Add optional variable name to portMappings to allow Service Discovery registration

why

  • Unable to allow ECS container definitions to register with Service Discovery

references

@aaronlake aaronlake requested review from a team as code owners June 30, 2023 21:05
@milldr
Copy link
Sponsor Member

milldr commented Aug 5, 2023

/terratest

@milldr
Copy link
Sponsor Member

milldr commented Aug 5, 2023

please build the readme for the variable update:

make init
make readme

@aaronlake
Copy link
Contributor Author

Updated documentation

@jamengual
Copy link

Updated documentation

we have new commit commands

make precommit/terratest

it will do a bunch of things including updating docs and such

@jamengual
Copy link

/terratest

@max-lobur max-lobur merged commit 19bc586 into cloudposse:main Sep 26, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-lobur max-lobur max-lobur approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The port_mappings variable needs to include the "name" parameter to support Service Connect integration.
4 participants
@aaronlake @milldr @jamengual @max-lobur