Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add service connect fields to portMapping #168

Merged
merged 5 commits into from Sep 29, 2023
Merged

chore: add service connect fields to portMapping #168

merged 5 commits into from Sep 29, 2023

Conversation

dudymas
Copy link
Contributor

@dudymas dudymas commented Aug 9, 2023

what

  • added name and appProtocol to portMapping variables

why

  • Service Connect uses these fields

references

@dudymas dudymas requested review from a team as code owners August 9, 2023 16:28
@dudymas dudymas force-pushed the chore/ports/support-service-connect branch from 844223a to 9c6f57d Compare August 10, 2023 20:53
@dudymas
Copy link
Contributor Author

dudymas commented Aug 10, 2023

/terratest

@dudymas dudymas force-pushed the chore/ports/support-service-connect branch from 237e8d5 to 0ddf722 Compare September 29, 2023 14:17
@dudymas
Copy link
Contributor Author

dudymas commented Sep 29, 2023

/terratest

@dudymas dudymas force-pushed the chore/ports/support-service-connect branch from 0ddf722 to 7ada69e Compare September 29, 2023 14:25
@dudymas
Copy link
Contributor Author

dudymas commented Sep 29, 2023

/terratest

@dudymas dudymas enabled auto-merge (squash) September 29, 2023 14:32
@dudymas dudymas merged commit b0b4c40 into main Sep 29, 2023
16 checks passed
@dudymas dudymas deleted the chore/ports/support-service-connect branch September 29, 2023 14:42
@max-lobur max-lobur mentioned this pull request Sep 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-lobur max-lobur max-lobur approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dudymas @max-lobur