feat: update terraform-aws-ecs-codepipeline dependency

[jhosteny]

what

• Plumbed the github_anonymous variable from the https://github.com/cloudposse/terraform-aws-ecs-codepipeline/ module through this module as a variable

why

• Allow modules using this one to run without codepipeline and the associated GitHub web hooks

references

• Expose variable that was introduced by cloudposse/terraform-aws-ecs-codepipeline@524844c

[Gowiem]

/test all

[Gowiem]

@jhosteny Mind trying to pass github_webhooks_anonymous = true to the example/complete to see how that works out? We're having test failures with this module recently revolving around the codepipeline GH provider. Wondering if that will fix things...

[jhosteny]

Hi @Gowiem - I just added this. I'll keep an eye out for the next status check to see if there are further issues.

[Gowiem]

/test all

[Gowiem]

@jhosteny Ah sorry, gotta request another change -- Tests failed with:

Error: If `anonymous` is true, `token` cannot be set.

Can you set the token variable to null?

[Gowiem]

/test all

[jhosteny]

Hi @Gowiem, I just pushed before your comment. I deleted it, but the default is an empty string. It looks like you just kicked the test off again, so I will wait to investigate if that needs to be explicitly null. Thanks for helping get this through.

[jhosteny]

@Gowiem this seems to be a different (unrelated to this PR) failure now. I'll be able to dig into it further after the weekend.

[Gowiem]

@jhosteny Yeah, that is unrelated to your work I believe. Those might be transient errors... as we've had a number of issues with S3 buckets in the past (though I'm not sure about the ALB issue).

I'll fire off the terratests again and we'll see.

[Gowiem]

/test terratest

[Gowiem]

Huh seems to be recurring... Now I'm wondering if one of the terratest's tf destorys didn't properly remove all the resources for these tests. If that's the case, we have aws-nuke running against the CP test environment on a schedule so that should eventually sort itself out. Let's sync back up on this one in a few days.

[jhosteny]

@Gowiem thanks! I'll check back in later this week on it.

[jamengual]

/test terratest

[jhosteny]

@osterman @jamengual arrgh. It looks like the GH provider was just tagged at 2.9.0 6 hours ago, and between 2.8.1 and 2.9.0, the anonymous setting was removed. I think the https://github.com/cloudposse/terraform-github-repository-webhooks module will need to be changed yet again to either set the pessimistic constraint operator to ~> 2.8.0, or fixed to work with >= 2.9. I'm not sure why they removed that option in a minor release.

[osterman]

/test terratest

[jhosteny]

/test terratest

[osterman]

@jhosteny try rebasing... I think @jamengual has fixed tests on this module.

[jhosteny]

/test all