Update: Move from deprecated list used in dynamic-subnet/aws #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/aws" 0.38.0 to latest version
While running complete example terraform validate (version 0.15+) will throw error because cloudposse/dynamic-subnets/aws" 0.38.0 version uses list datatype which is deprecated
```
output "nat_ips" {
description = "IP Addresses in use for NAT"
value = coalescelist(aws_eip.default.*.public_ip, aws_eip.nat_instance.*.public_ip, data.aws_eip.nat_ips.*.public_ip, list(""))
}
```
https://github.com/cloudposse/terraform-aws-dynamic-subnets/blob/0.38.0/outputs.tf
Using the latest version 0.39+ will resolve this error
Nuru
added
terraform/0.15
no-release
|
/test all |
|
@savannahar68 Thank you for this contribution. This PR is currently blocked due to failing tests. However, the test failures are not your fault, the problem is that some of our tests are not compatible with Terraform 0.15. That means you will not be able to fix the failures, so don't even try. We will update the tests and re-run them. |
|
@Nuru thanks for the update 👍🏻 Looking forward to PR getting merged. |
|
This pull request has been automatically closed by Mergify because there are no longer any changes. |
|
@savannahar68 Your change was included in v0.42.1 so you would not have to wait for our testing to catch up. Thank you again for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running complete example terraform validate (version 0.15+) will throw error because cloudposse/dynamic-subnets/aws" 0.38.0 version uses list datatype which is deprecated
https://github.com/cloudposse/terraform-aws-dynamic-subnets/blob/0.38.0/outputs.tf
Using the latest version 0.39+ will resolve this error
what
why