Update Security Group #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test all |
|
/test all |
|
/test all |
|
/test all |
nitrocode
reviewed
Jan 7, 2022
nitrocode
reviewed
Jan 7, 2022
There was a problem hiding this comment.
- Has this been tested in a current customer?
- I’m worried that the security group that was created by the cluster may be used in downstream components by accessing the eks remote states
- Does this PR need to also update the migration doc https://github.com/cloudposse/terraform-aws-eks-cluster/blob/master/docs/migration-0.44.x-0.45.x%2B.md ?
|
/test all |
|
/test all |
|
/test all |
nitrocode
reviewed
Jan 8, 2022
nitrocode
reviewed
Jan 8, 2022
nitrocode
reviewed
Jan 8, 2022
nitrocode
previously approved these changes
Jan 8, 2022
|
/test all |
nitrocode
reviewed
Jan 8, 2022
nitrocode
previously approved these changes
Jan 8, 2022
Co-authored-by: nitrocode <nitrocode@users.noreply.github.com>
|
/test all |
nitrocode
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
This module creates an EKS cluster, which automatically creates an EKS-managed Security Group in which all managed nodes are placed automatically by EKS, and unmanaged nodes could be placed
by the user, to ensure the nodes and control plane can communicate.
Before version
0.45.0, this module, by default, created an additional Security Group. Prior to version0.19.0of this module, that additional Security Group was the only one exposed bythis module (because EKS at the time did not create the managed Security Group for the cluster), and it was intended that all worker nodes (managed and unmanaged) be placed in this
additional Security Group. With version
0.19.0, this module exposed the managed Security Group created by the EKS cluster, in which all managed node groups are placed by default. We nowrecommend placing non-managed node groups in the EKS-created Security Group as well by using the
allowed_security_group_idsvariable, and not create an additional Security Group.references
related