Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add k8s provider config variables #78

Merged
merged 5 commits into from Sep 23, 2020
Merged

feat: add k8s provider config variables #78

merged 5 commits into from Sep 23, 2020

Conversation

dotCipher
Copy link
Contributor

@dotCipher dotCipher commented Sep 23, 2020 •
edited

what

  • Adds variable for kubernetes.load_config_file configuration via kubernetes_load_config_file
  • Add variable for kubernetes.config_path configuration via kubernetes_config_path

why

  • Allow bypassing issues with clusters provisioned with different users by migrating from null config map resource to native kubernetes provider config map resource

references

@dotCipher dotCipher requested review from a team as code owners September 23, 2020 15:45
@aknysh
Copy link
Member

aknysh commented Sep 23, 2020 •
edited

@dotCipher thanks, it's useful.
In this case, maybe we can also add the config_path option (default to ~/.kube/config) so people wold be able to change the default path.
https://registry.terraform.io/providers/hashicorp/kubernetes/latest/docs#config_path

@aknysh
Copy link
Member

aknysh commented Sep 23, 2020

/rebuild-readme

aknysh
aknysh reviewed Sep 23, 2020
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@dotCipher
Copy link
Contributor Author

Awesome yeah, I'll add that

@dotCipher
Copy link
Contributor Author

/rebuild-readme

@dotCipher dotCipher changed the title feat: add variable for loading k8s config file feat: add k8s provider config variables Sep 23, 2020
@dotCipher
Copy link
Contributor Author

@aknysh let me know if that works 😄

@aknysh
Copy link
Member

aknysh commented Sep 23, 2020

/rebuild-readme

@aknysh
Copy link
Member

aknysh commented Sep 23, 2020

/terraform-fmt

@aknysh
Copy link
Member

aknysh commented Sep 23, 2020

/test all

@aknysh aknysh merged commit 77dc7dd into cloudposse:master Sep 23, 2020
@Nuru Nuru mentioned this pull request Jan 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@woz5999 woz5999 Awaiting requested review from woz5999

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow k8s config file load
3 participants
@dotCipher @aknysh @actions-bot