Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add force_update_version and replace_node_group_on_version_update variables #151

Merged
merged 8 commits into from
Sep 26, 2023

Conversation

aknysh
Copy link
Member

@aknysh aknysh commented Sep 26, 2023

what

  • Add force_update_version and replace_node_group_on_version_update variables

why

  • force_update_version allows forcing version update if existing pods are unable to be drained due to a pod disruption budget issue. Default is false for backwards compatibility

  • If the variable replace_node_group_on_version_update is set to true and the EKS cluster is updated to a new Kubernetes version, the Node Groups will be replaced instead of updated in-place. This is useful when updating very old EKS clusters to a new Kubernetes version where some old releases prevent nodes from being drained (due to PodDisruptionBudget or taint/toleration issues), but replacing the Node Groups works without forcing the pods to leave the old nodes by using the force_update_version variable. This is related, for example, to istio. Default is false for backwards compatibility

references

@aknysh aknysh requested a review from Nuru September 26, 2023 16:33
@aknysh aknysh self-assigned this Sep 26, 2023
@aknysh aknysh requested review from a team as code owners September 26, 2023 16:33
@aknysh
Copy link
Member Author

aknysh commented Sep 26, 2023

/terratest

@aknysh
Copy link
Member Author

aknysh commented Sep 26, 2023

/terratest

@aknysh
Copy link
Member Author

aknysh commented Sep 26, 2023

/terratest

@aknysh
Copy link
Member Author

aknysh commented Sep 26, 2023

/terratest

@aknysh aknysh changed the title Add force_update_version and include_kubernetes_version_in_keepers variables Add force_update_version and force_node_group_replacement variables Sep 26, 2023
Copy link

@kcarter-bread kcarter-bread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@aknysh aknysh changed the title Add force_update_version and force_node_group_replacement variables Add force_update_version and replace_node_group_on_version_upodate variables Sep 26, 2023
@aknysh aknysh changed the title Add force_update_version and replace_node_group_on_version_upodate variables Add force_update_version and replace_node_group_on_version_update variables Sep 26, 2023
@aknysh
Copy link
Member Author

aknysh commented Sep 26, 2023

/terratest

variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
aknysh and others added 3 commits September 26, 2023 17:23
Co-authored-by: Nuru <Nuru@users.noreply.github.com>
Co-authored-by: Nuru <Nuru@users.noreply.github.com>
@aknysh
Copy link
Member Author

aknysh commented Sep 26, 2023

/terratest

@aknysh aknysh requested a review from Nuru September 26, 2023 21:54
@aknysh aknysh merged commit 6ccf1a9 into main Sep 26, 2023
10 checks passed
@aknysh aknysh deleted the add-force-update-version branch September 26, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants