More triggers for replacement, better handling of enabled=false #32

Nuru · 2020-09-08T00:24:41Z

what

Fix edge cases where certain inputs would cause errors when the module enabled = false
Make cluster name dependent on additional variables so that it changes whenever the node group needs to be replaced

Module should always work (and create no resources) when var.enabled = false as long as other variables are valid
Terraform will fail when create_before_destroy is set if it needs to replace the node group but the name does not change

Nuru · 2020-09-08T00:28:16Z

/test all

Nuru · 2020-09-08T01:29:45Z

/test all

More triggers for replacement, better handling of enabled=false

1be7aaa

Nuru added terraform/0.13 Module requires Terraform 0.13 or later bugfix Change that restores intended behavior labels Sep 8, 2020

Nuru requested review from a team as code owners September 8, 2020 00:24

Nuru requested review from jhosteny and joe-niland and removed request for a team September 8, 2020 00:24

Nuru requested review from aknysh and removed request for jhosteny and joe-niland September 8, 2020 00:29

Nuru mentioned this pull request Sep 8, 2020

Fix for remote access and lifecycle issues #30

Merged

Remove escapes before quotes in hereis block

8020b93

aknysh approved these changes Sep 8, 2020

View reviewed changes

Nuru merged commit a93cdea into master Sep 8, 2020

Nuru deleted the enabled branch September 8, 2020 01:54