New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement optional additional principals #51
feat: Implement optional additional principals #51
Conversation
I assume that I don't have any influence on this error |
Signed-off-by: Tim Schwenke <tim.and.trallnag+code@gmail.com>
There seems to be a bug regarding using named iterators. So I replaced it with the default named variable. See here: <hashicorp/terraform#22340> Signed-off-by: Tim Schwenke <tim.and.trallnag+code@gmail.com>
@trallnag Thank you for your PR. Please We are still considering some subtle points about your PR, such as the variable name, but should have an answer for you soon. Are there any other Cloud Posse Terraform modules where you think you will want to make the same change? |
Hey @Nuru,
For me personally the other |
@trallnag Please expand on the list you would like to see changed. Like you, we want to have this discussion just once (here) and solve it for all the modules you are going to want to update in the foreseeable future. It will help us to see all the use cases to ensure that we come up with a robust solution that can be consistently applied across all the modules. |
…eks-node-group into feature/additional-assume-role-statements
@Nuru, here is the list:
But these are modules I would be using / I already use |
This pull request is now in conflict. Could you fix it @trallnag? 🙏 |
what
This PR adds a variable that allows users to declare additional principals that should be included in the assume role policy.
why
Where I work the managed AWS accounts enforce that every role should be able be assumed by a "watchdog" role. If a role does not contain this trusted relationship, it will be added automatically and lead to Terraform drift.
todo
If this PR is in principle acceptable I would require tips / help:
terraform fmt
changes?