add variable for http_put_response_hop_limit #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he launch template depends on
Additional security groups
add variable for http_put_response_hop_limit
|
This pull request is now in conflict. Could you fix it @tarfik? 🙏 |
|
@tarfik Thank you for this contribution. This is a difficult module to work with and you did well. I do not understand the dates and timing of this PR exactly, but the feature you requested regarding http_put_response_hop_limit was added in #63 and released in v0.20.0 of this module. Changes from #66 will be addressed in that PR. Closing this PR as duplicate/not needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
changes from #66
and
get http_put_response_hop_limit from variables
why
If we need to disable metadata API for pods without serviceaccount and network!=host we need to set http_put_response_hop_limit == 1.
references
https://docs.aws.amazon.com/eks/latest/userguide/best-practices-security.html#restrict-ec2-credential-access