Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: add depends_on instance profile for EB env #267

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Fix: add depends_on instance profile for EB env #267

merged 1 commit into from
Jun 24, 2024

Conversation

QuentinBtd
Copy link
Contributor

what

Add depends_on in elastic_beanstalk_environment

why

If instance profile is created after the environment, the creation of this last will failed.

references

I just encountered the problem;

The instance profile my-env-eb-ec2 associated with the environment does not exist.

@mergify mergify bot added the triage Needs triage label Jun 24, 2024
@QuentinBtd QuentinBtd marked this pull request as ready for review June 24, 2024 13:05
@QuentinBtd QuentinBtd requested review from a team as code owners June 24, 2024 13:05
@aknysh
Copy link
Member

aknysh commented Jun 24, 2024 •
edited by github-actions bot
Loading

These changes were released in v0.52.0.

aknysh
aknysh approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @QuentinBtd

@aknysh aknysh added minor New features that do not break anything and removed triage Needs triage labels Jun 24, 2024
@aknysh aknysh merged commit cce5a7e into cloudposse:main Jun 24, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
minor New features that do not break anything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@QuentinBtd @aknysh