Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVOPS-232: Add aws:elasticbeanstalk:cloudwatch:logs support #59

Merged

Conversation

johncblandii
Copy link
Contributor

@johncblandii johncblandii commented Oct 31, 2018

Feature

Support log settings.

Solution

  • Added support for aws:elasticbeanstalk:hostmanager, aws:elasticbeanstalk:cloudwatch:logs, and aws:elasticbeanstalk:cloudwatch:logs:health options

https://docs.aws.amazon.com/elasticbeanstalk/latest/dg/environments-cfg-logging.html

Testing

  • Tested locally with a parent module worked as expected

screen shot 2018-10-31 at 5 26 53 pm

@johncblandii
Copy link
Contributor Author

// CC @osterman @aknysh

namespace = "aws:elasticbeanstalk:cloudwatch:logs:health"
name = "RetentionInDays"
value = "${var.health_streaming_retention_in_days}"
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just moved these up to the Logging section just to follow the approach with sections.

@osterman osterman requested a review from aknysh November 1, 2018 05:51
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @johncblandii

@aknysh aknysh merged commit 138e006 into cloudposse:master Nov 1, 2018
@johncblandii johncblandii deleted the feature/logging-improvements branch November 1, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants