Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump security group module version #210

Merged
merged 4 commits into from Dec 14, 2023
Merged

chore: bump security group module version #210

merged 4 commits into from Dec 14, 2023

Conversation

andrewhertog
Copy link
Contributor

@andrewhertog andrewhertog commented Dec 6, 2023 •
edited by aknysh

what

  • The security group module dependency has been upgraded to include a major fix to how it manages rules

why

  • Using the old version made changes to security group rules hard to deal with.

references

https://github.com/cloudposse/terraform-aws-security-group/releases
https://sweetops.slack.com/archives/CB6GHNLG0/p1701898649784559

related

@andrewhertog
chore: bump security group module version
9bdfbce 
Signed-off-by: Andrew den Hertog <andrew@denhertog.ca>
@andrewhertog andrewhertog requested review from a team as code owners December 6, 2023 21:54
@andrewhertog
chore: gen docs
8d2456d 
Signed-off-by: Andrew den Hertog <andrew@denhertog.ca>
@aknysh
Copy link
Member

aknysh commented Dec 7, 2023

/terratest

aknysh
aknysh reviewed Dec 7, 2023
View reviewed changes
main.tf Show resolved Hide resolved
aknysh
aknysh reviewed Dec 7, 2023
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewhertog please see comments

after that, please run

make init
make github/init
make readme

and commit the changes

aknysh
aknysh requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@andrewhertog
task: make new vars avaialbe
632c44e 
Signed-off-by: Andrew den Hertog <andrew@denhertog.ca>
@andrewhertog
Copy link
Contributor Author

@aknysh I've made the changes requested

aknysh
aknysh reviewed Dec 13, 2023
View reviewed changes
main.tf Show resolved Hide resolved
aknysh
aknysh reviewed Dec 13, 2023
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewhertog please address the last comment, thanks

@andrewhertog
chore: run format:
f5e9352 
Signed-off-by: Andrew den Hertog <andrew@denhertog.ca>
@aknysh
Copy link
Member

aknysh commented Dec 14, 2023

/terratest

aknysh
aknysh approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @andrewhertog

@aknysh aknysh merged commit 8eb5183 into cloudposse:main Dec 14, 2023
9 checks passed
@andrewhertog andrewhertog deleted the chore/update-sg-dep branch December 14, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andrewhertog @aknysh