Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_kms_key_id: Allow user to supply their own kms_key_id #75

Merged
merged 2 commits into from Aug 18, 2020
Merged

add_kms_key_id: Allow user to supply their own kms_key_id #75

merged 2 commits into from Aug 18, 2020

Conversation

ac-hibbert
Copy link
Contributor

Change-Id: I23d1288851301328afaa61686b42d8376d303415

what

  • This change allows a user to supply their own kms_key_id from a previously created kms key when at rest encryption is enabled

why

  • Security

references

  • N/A

add_kms_key_id: Allow user to supply their own kms_key_id
299104b 
Change-Id: I23d1288851301328afaa61686b42d8376d303415
@ac-hibbert ac-hibbert requested a review from a team as a code owner August 12, 2020 17:02
@ac-hibbert ac-hibbert requested review from adamcrews and nitrocode and removed request for a team August 12, 2020 17:02
@ac-hibbert
Copy link
Contributor Author

@nitrocode, @osterman, @adamcrews could I get a review on this?

@nitrocode
Copy link
Member

/rebuild-readme

@nitrocode
Copy link
Member

/test all

@osterman osterman merged commit f727ef5 into cloudposse:master Aug 18, 2020
@Nuru Nuru mentioned this pull request Jul 12, 2021
Closed
brian-weis-msr pushed a commit to Measurabl/terraform-aws-elasticache-redis that referenced this pull request Apr 2, 2024
@ac-hibbert @actions-bot @brian-weis-msr
add_kms_key_id: Allow user to supply their own kms_key_id (cloudposse#75
07f96b4 
)

* add_kms_key_id: Allow user to supply their own kms_key_id

Change-Id: I23d1288851301328afaa61686b42d8376d303415

* Updated README.md

Co-authored-by: Andy Hibbert <anhibber@cisco.com>
Co-authored-by: actions-bot <58130806+actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@adamcrews adamcrews Awaiting requested review from adamcrews

@nitrocode nitrocode Awaiting requested review from nitrocode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ac-hibbert @nitrocode @osterman @actions-bot