Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firewall-manager-waf_v2): add missing attributes #36

Merged
merged 3 commits into from Aug 16, 2023
Merged

feat(firewall-manager-waf_v2): add missing attributes #36

merged 3 commits into from Aug 16, 2023

Conversation

eladlevi-dy
Copy link
Contributor

add missing attribues that cause drifts.

  • add attributes customRequestHandling, customResponse and sampledRequestsEnabledForDefaultActions.

why

  • These attributes are part of the firewall manager wafv2 policy values and had to be addressed in the module, otherwise there will be drift any time "drift detection" runs.
      ~ security_service_policy_data {
          ~ managed_service_data = jsonencode(
              ~ {
                  - customRequestHandling                   = null -> null
                  - customResponse                          = null -> null
                  - sampledRequestsEnabledForDefaultActions = null -> null
                    # (6 unchanged elements hidden)
                }
            )
            # (1 unchanged attribute hidden)
        }
        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

references

Link to AWS API_SecurityServicePolicyData

@eladlevi-dy eladlevi-dy marked this pull request as ready for review August 16, 2023 11:06
@eladlevi-dy eladlevi-dy requested review from a team as code owners August 16, 2023 11:06
@milldr
Copy link
Sponsor Member

milldr commented Aug 16, 2023

/terratest

@milldr milldr merged commit fc7ff1c into cloudposse:main Aug 16, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants