Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(firewall-manager-shield_advanced): add missing attributes #38

Merged
merged 5 commits into from Sep 22, 2023

Conversation

eladlevi-dy
Copy link
Contributor

add missing attribues that cause drifts.

add attributes automaticResponseStatus, automaticResponseAction and overrideCustomerWebaclClassic.

why

These attributes are part of the firewall manager shield advanced policy values and had to be addressed in the module, otherwise there will be drift any time "drift detection" runs.

      ~ security_service_policy_data {
          ~ managed_service_data = jsonencode(
              ~ {
                  - automaticResponseConfiguration = {
                      - automaticResponseAction = null
                      - automaticResponseStatus = "IGNORED"
                    } -> null
                  - overrideCustomerWebaclClassic  = false -> null
                    # (1 unchanged element hidden)
                }
            )
            # (1 unchanged attribute hidden)
        }
        # (2 unchanged blocks hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

references

Link to AWS doc.

@eladlevi-dy eladlevi-dy marked this pull request as ready for review September 11, 2023 13:24
@eladlevi-dy eladlevi-dy requested review from a team as code owners September 11, 2023 13:24
@eladlevi-dy
Copy link
Contributor Author

/terratest

@aknysh
Copy link
Member

aknysh commented Sep 12, 2023

@eladlevi-dy thanks for the PR.

please run the following commands and commit the changes

terraform fmt

make init
make github/init
make readme

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@aknysh
Copy link
Member

aknysh commented Sep 20, 2023

@eladlevi-dy thanks, but we need to fix another issue, please see https://github.com/cloudposse/terraform-aws-firewall-manager/actions/runs/6251619507/job/16974040715?pr=38

README.md is outdated. Please run the following commands locally and push the file:
  make init
  make readme

please run the following commands and commit the changes

make init
make github/init
make readme

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

@eladlevi-dy
Copy link
Contributor Author

@aknysh
make readme did not finish successfully, I fixed the readme manually.

@aknysh
Copy link
Member

aknysh commented Sep 22, 2023

/terratest

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @eladlevi-dy

@aknysh aknysh merged commit dd16b52 into cloudposse:main Sep 22, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants