New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(firewall-manager-shield_advanced): add missing attributes #38
Conversation
/terratest |
@eladlevi-dy thanks for the PR. please run the following commands and commit the changes terraform fmt
make init
make github/init
make readme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see comments
@eladlevi-dy thanks, but we need to fix another issue, please see https://github.com/cloudposse/terraform-aws-firewall-manager/actions/runs/6251619507/job/16974040715?pr=38
please run the following commands and commit the changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see comments
@aknysh |
/terratest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @eladlevi-dy
add missing attribues that cause drifts.
add attributes
automaticResponseStatus
,automaticResponseAction
andoverrideCustomerWebaclClassic
.why
These attributes are part of the firewall manager shield advanced policy values and had to be addressed in the module, otherwise there will be drift any time "drift detection" runs.
references
Link to AWS doc.