-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect S3 and Org Auto-enable #20
Protect S3 and Org Auto-enable #20
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bridgecrew has found infrastructure configuration errors in this PR ⬇️
@@ -4,6 +4,22 @@ | |||
resource "aws_guardduty_detector" "guardduty" { | |||
enable = module.this.enabled | |||
finding_publishing_frequency = var.finding_publishing_frequency | |||
datasources { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure GuardDuty is enbaled to specific org/region
Resource: aws_guardduty_detector.guardduty | ID: BC_AWS_GENERAL_66
How to Fix
resource "aws_guardduty_detector" "ok" {
enable = true
}
resource "aws_guardduty_organization_configuration" "example" {
auto_enable = true
detector_id = aws_guardduty_detector.ok.id
}
Description
TBADependent Resources
Calculating...
@@ -4,6 +4,22 @@ | |||
resource "aws_guardduty_detector" "guardduty" { | |||
enable = module.this.enabled | |||
finding_publishing_frequency = var.finding_publishing_frequency | |||
datasources { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure GuardDuty is enbaled to specific org/region
Resource: aws_guardduty_detector.guardduty | ID: BC_AWS_GENERAL_66
How to Fix
resource "aws_guardduty_detector" "ok" {
enable = true
}
resource "aws_guardduty_organization_configuration" "example" {
auto_enable = true
detector_id = aws_guardduty_detector.ok.id
}
Description
TBADependent Resources
Calculating...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change details
-
Error ID Change Path Resource BC_AWS_GENERAL_66 Added /main.tf aws_guardduty_detector.guardduty
This pull request is now in conflict. Could you fix it @kierang-contino? 🙏 |
This pull request is now in conflict. Could you fix it @kierang-contino? 🙏 |
This PR has been closed due to inactivity and merge conflicts. |
Thanks @kierang-contino for creating this pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while. While you wait, make sure to review our contributor guidelines. Tip Need help or want to ask for a PR review to be expedited?Join us on Slack in the |
Important Cloud Posse Engineering Team Review RequiredThis pull request modifies files that require Cloud Posse's review. Please be patient, and a core maintainer will review your changes. To expedite this process, reach out to us on Slack in the |
what
why
references