Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add permission boundary as variable and pass to downstream module #52

Merged
merged 2 commits into from Feb 22, 2023
Merged

Add permission boundary as variable and pass to downstream module #52

merged 2 commits into from Feb 22, 2023

Conversation

eriweb
Copy link
Contributor

@eriweb eriweb commented Feb 13, 2023

what

  • Adds the possibility to pass a permission boundary to the created user

why

  • We, amongst others, require system users to have a permission boundary attached to them. This is to prevent accidental (or intended) too wide permission sets.
  • The downstream iam-system-user module has a variable for it, this commit adds the same variable and passes it down

@eriweb eriweb requested review from a team as code owners February 13, 2023 11:59
@oleptho
Copy link

oleptho commented Feb 21, 2023

This would be great! We also need permission boundary.

@eriweb eriweb force-pushed the feature/add_permission_boundary_variable branch from e74933b to 0f1474b Compare February 22, 2023 09:49
@aknysh
Copy link
Member

aknysh commented Feb 22, 2023

/test all

aknysh
aknysh approved these changes Feb 22, 2023
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @eriweb

@aknysh aknysh merged commit c8d7992 into cloudposse:master Feb 22, 2023
QuentinBtd pushed a commit to QuentinBtd/fork_cloudposse_terraform-aws-iam-s3-user that referenced this pull request Mar 8, 2024
@eriweb @QuentinBtd
Add permission boundary as variable and pass to downstream module (cl…
64a33d2 
…oudposse#52)

* Add permission boundary as variable and pass to downstream module

* Auto Format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 was automatically assigned from cloudposse/contributors

@RothAndrew RothAndrew Awaiting requested review from RothAndrew RothAndrew was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eriweb @oleptho @aknysh