Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: module enablement; Import Key Test #65

Merged
merged 2 commits into from
Jul 9, 2021
Merged

Fix: module enablement; Import Key Test #65

merged 2 commits into from
Jul 9, 2021

Conversation

korenyoni
Copy link
Member

what

  • Ensure module adheres var.enabled
  • fix tests and ensure examples_import_key_test is run in test suite

why

  • Resources were created even when var.enabled was false

references

@korenyoni korenyoni requested review from a team as code owners July 9, 2021 18:10
@korenyoni korenyoni requested review from jamengual and brcnblc and removed request for a team July 9, 2021 18:10
@korenyoni korenyoni added the bug 🐛 An issue with the system label Jul 9, 2021
@korenyoni
Copy link
Member Author

/test all

@nitrocode nitrocode added the patch A minor, backward compatible change label Jul 9, 2021
@korenyoni korenyoni merged commit 6433b2a into master Jul 9, 2021
@korenyoni korenyoni deleted the fix/module-enablement branch July 9, 2021 18:17
@korenyoni korenyoni mentioned this pull request Jul 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@jamengual jamengual Awaiting requested review from jamengual

@brcnblc brcnblc Awaiting requested review from brcnblc

Assignees
No one assigned
Labels
bug 🐛 An issue with the system patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@korenyoni @nitrocode @cloudpossebot