feat(aws-key-pair): enable the ssm parameter store to record the key-pair distribution #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Gowiem & @korenyoni , Thank you |
Gowiem
requested changes
Jul 26, 2023
There was a problem hiding this comment.
@haidargit generally, looks good, but I changed around some naming + description + style to fit the Cloud Posse guidelines.
Let me know if you have any questions. Once you accept + commit these changes, you'll need to pull them and run make init && make readme locally and then commit + push the result.
Thanks for your contribution!
…pair distribution enforce ssm parameter to SecureString Co-authored-by: Matt Gowie <matt@masterpoint.io> enforce ssm parameter to SecureString Co-authored-by: Matt Gowie <matt@masterpoint.io> adjust ssm parameter path prefix Co-authored-by: Matt Gowie <matt@masterpoint.io> fix bool-typed variable naming Co-authored-by: Matt Gowie <matt@masterpoint.io> ssm parameter enabled var name Co-authored-by: Matt Gowie <matt@masterpoint.io> ssm parameter path prefix Co-authored-by: Matt Gowie <matt@masterpoint.io> feat(aws-key-pair): enable the ssm parameter store to record the key-pair distribution
haidargit
force-pushed
the
feature/enable-aws-ssm-parameter-store-for-key-pair
branch
from
ad34190
to
57a696c
Compare
|
Thanks! @Gowiem can you help to check again? Thank you |
Gowiem
reviewed
Jul 26, 2023
|
/terratest |
Gowiem
previously approved these changes
Jul 26, 2023
Gowiem
reviewed
Jul 26, 2023
|
/terratest |
Gowiem
reviewed
Jul 26, 2023
|
/terratest |
Gowiem
reviewed
Jul 26, 2023
|
/terratest |
Gowiem
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
In this PR, we can use the AWS SSM Parameter store resource to facilitate the secure management of private key information. This resource allows us to gather the private key information generated by the current module and securely store it in the parameter store.
why
The objective behind this enhancement is to ensure the secure distribution of private key ownership within the AWS infrastructure. We can centrally manage and protect sensitive information, increasing operational efficiency and reducing the likelihood of unauthorized access to critical resources.
references
No issue relates to current improvement.
I have run these required commands,
make initmake readmeKindly review this PR for module improvements. Thank you