Dynamic logs block

[heathsnow]

what

• RabbitMQ support via dynamic logs block
  • RabbitMQ general logs cannot be enabled.
    • aws_mq_broker RabbitMQ general logs cannot be enabled hashicorp/terraform-provider-aws#18067

why

• Support engine_type = "RabbitMQ"

references

• aws_mq_broker RabbitMQ general logs cannot be enabled hashicorp/terraform-provider-aws#18067

• Closes Error building RabbitMQ : Audit logging is not supported for RabbitMQ brokers #24 insofar as the provider doesn't currently support enabling general logging at this time.
• I think engine_type seems to support only ActiveMQ #18 can also be closed.

[Gowiem]

@heathsnow since this is currently just a bug in the provider, I'm hesitant to say that we should completely remove the ability to enable general logs at this time. The upstream bug in the provider should be fixed (which is seems that the Hashi team is on top of to some degree) instead of removing the ability to utilize this flag all together.

If you want to open a PR to mention this issue in the README or as a comment on that variable then I believe we'd be happy to accept that, but for now this just looks like a bug that is upstream that could be fixed any day now in which case we'd need to revert your change.

[heathsnow]

@Gowiem Perhaps if I update the logic so that if both general AND audit logs are set to false then the logs block is removed? This would fix the issue of not supporting RabbitMQ right now and still allow for general logging to be enabled in the future once the provider is fixed.

[Gowiem]

@heathsnow that sounds better and acceptable to me 👍

FYI, I'm utilizing this module for RMQ usage in a client project and while I didn't implement the usage of it myself... it looks like my client's team got around the issues of the logs block causing issues by setting both audit_log_enabled and general_log_enabled to null, which seems to allow the provider to be happy. That said, I think your the false + false sounds preferable, so let's go that route. Please be sure to put a NOTE comment at the top of that dynamic block which links to the provider issue in question.

Thanks!

[heathsnow]

@Gowiem PR Feedback applied (Omit logs if both general and audit logs disabled).

[Gowiem]

/test all

[Gowiem]

👍 Hopefully this will cause a little less confusion for folks using RMQ -- Thanks!

[Gowiem]

@heathsnow sadly we're blocked by this annoying aws provider bug which is plaguing lots of projects: hashicorp/terraform-provider-aws#18550

TestExamplesComplete 2021-04-07T13:34:12Z logger.go:66: Error: error creating SSM parameter: ValidationException: Invalid request: tags and overwrite can't be used together. To create a parameter with tags, please remove overwrite flag. To update tags for an existing parameter, please use AddTagsToResource or RemoveTagsFromResource.

For now, I think we'll need to hold off on this one until hopefully that bug is fixed in v3.36 of the provider.

[Gowiem]

/test all

[Gowiem]

@heathsnow Thanks for the contribution! Released as 0.13.0.