Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security_group_rule_description #51

Merged
merged 3 commits into from
Dec 22, 2021
Merged

Add security_group_rule_description #51

merged 3 commits into from
Dec 22, 2021

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Dec 13, 2021 •
edited
Loading

what

  • Add security_group_rule_description

why

  • If multiple allowed_cidr_blocks are supplied, the description will be duplicated. This fix will still create the duplication of the description but at least the description can be updated to include the cidr descriptions.

references

@nitrocode nitrocode added the patch A minor, backward compatible change label Dec 13, 2021
@nitrocode nitrocode requested review from a team as code owners December 13, 2021 19:44
@nitrocode nitrocode mentioned this pull request Dec 13, 2021
Closed
@korenyoni
Copy link
Member

/test all

korenyoni
korenyoni approved these changes Dec 13, 2021
View reviewed changes
Copy link
Member

@korenyoni korenyoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this customizability makes sense.

@nitrocode nitrocode merged commit 7e6441a into master Dec 22, 2021
@nitrocode nitrocode deleted the security_group_rule_description branch December 22, 2021 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korenyoni korenyoni korenyoni approved these changes

@SweetOps SweetOps Awaiting requested review from SweetOps SweetOps was automatically assigned from cloudposse/contributors

@brcnblc brcnblc Awaiting requested review from brcnblc brcnblc was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nitrocode @korenyoni @cloudpossebot