Feat: add security groups options #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change the default value of the "security_group_enabled" variable from true to false Signed-off-by: Quentin BERTRAND <contact@quentinbertrand.fr>
- Modify the `resource "aws_security_group_rule" "default_ingress"` block in `main.tf` to use `var.default_listener_ingress_cidr_blocks` and `var.default_listener_ingress_prefix_list_ids` - Add a new variable `variable "security_group_ids"` in `variables.tf` - Add a new variable `variable "default_listener_ingress_cidr_blocks"` in `variables.tf` - Add a new variable `variable "default_listener_ingress_prefix_list_ids"` in `variables.tf` Signed-off-by: Quentin BERTRAND <contact@quentinbertrand.fr>
- Add an output for the security group ID of the NLB Signed-off-by: Quentin BERTRAND <contact@quentinbertrand.fr>
- Add `security_group_enabled = true` to `fixtures.us-east-2.tfvars` - Add `security_group_enabled` variable to the `nlb` module in `main.tf` Signed-off-by: Quentin BERTRAND <contact@quentinbertrand.fr>
aknysh
previously requested changes
Jan 29, 2024
There was a problem hiding this comment.
@QuentinBtd thanks for the PR
Please address:
README.md is outdated. Please run the following commands locally and push the files:
make init
make github/init
make readme
- Add `aws_security_group.default` resource - Add `aws_security_group_rule.default_ingress` resource - Add `aws_security_group_rule.egress` resource - Add `aws_security_group_rule.tls_ingress` resource - Add `input_default_listener_ingress_cidr_blocks` variable - Add `input_default_listener_ingress_prefix_list_ids` variable - Add `input_security_group_enabled` variable - Add `input_security_group_ids` variable - Add `input_tls_ingress_cidr_blocks` variable - Add `input_tls_ingress_prefix_list_ids` variable - Add `output_security_group_id` output Signed-off-by: Quentin BERTRAND <contact@quentinbertrand.fr>
|
@QuentinBtd sorry, please do it again, see https://github.com/cloudposse/terraform-aws-nlb/actions/runs/7699308430/job/20982416956?pr=53 |
I hadn't paid attention the first time, but; |
|
Hello @aknysh |
|
/terratest |
- Add a complete license in the README file Signed-off-by: Quentin BERTRAND <contact@quentinbertrand.fr>
|
|
|
/terratest |
|
/terratest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Add security groups options
why
We can associate NLB with security groups (only at NLB creation)
references
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/lb#security_groups