Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Activity Stream added #159

Merged
merged 18 commits into from
Mar 10, 2023

Conversation

ngoyal16
Copy link
Contributor

@ngoyal16 ngoyal16 commented Feb 26, 2023

what

  • Allow to create Activity Stream for RDS Cluster

Added by @Nuru:

  • Move PostgreSQL testing to proper test region (us-east-2)
  • Fix expected subnet CIDR due to fewer availability zones in us-east-2 than us-east-1
  • Increase test parallelism so that tests complete in under 60 minutes

why

  • Can be used to enable and activity stream from the cluster module itself

@ngoyal16 ngoyal16 requested review from a team as code owners February 26, 2023 06:27
@goruha goruha self-assigned this Feb 27, 2023
@goruha
Copy link
Member

goruha commented Feb 27, 2023

goruha
goruha previously requested changes Feb 27, 2023
Copy link
Member

@goruha goruha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs activity stream outputs

@goruha
Copy link
Member

goruha commented Feb 27, 2023

/test all

@goruha
Copy link
Member

goruha commented Feb 27, 2023

@ngoyal16 Tests failed

╷
│ Error: Missing resource instance key
│ 
│   on main.tf line 401, in resource "aws_rds_cluster_activity_stream" "primary":
│  401:   resource_arn = aws_rds_cluster.primary.arn
│ 
│ Because aws_rds_cluster.primary has "count" set, its attributes must be
│ accessed on specific instances.
│ 
│ For example, to correlate with indices of a referring resource, use:
│     aws_rds_cluster.primary[count.index]

@ngoyal16
Copy link
Contributor Author

/test all

@ngoyal16
Copy link
Contributor Author

@goruha i have added the outputs. also fix the issue related to cluster arn

@ngoyal16 ngoyal16 requested review from goruha and removed request for srhopkins and woz5999 February 27, 2023 15:58
@jamengual
Copy link
Contributor

/test all

@ngoyal16
Copy link
Contributor Author

@jamengual or @goruha can you help me to understand why the test cases has failed so that i can fix them.

@jamengual
Copy link
Contributor

you need to allow in your fork access for the action to push code to it, otherwise auto format will not work

@ngoyal16
Copy link
Contributor Author

ngoyal16 commented Feb 28, 2023

@jamengual can you please provide the steps to do it.?

@jamengual
Copy link
Contributor

can you see the failing checks? you can google the error, sorry I'm on my phone

@jamengual
Copy link
Contributor

/test terratest

@jamengual
Copy link
Contributor

/test all

@jamengual
Copy link
Contributor

@ngoyal16 I ping CloudPosse to see if they can bump up the vpc count.

@ngoyal16
Copy link
Contributor Author

ngoyal16 commented Mar 2, 2023

@jamengual thank you for your effort.

@ngoyal16
Copy link
Contributor Author

ngoyal16 commented Mar 3, 2023

@jamengual any update on same?

@jamengual
Copy link
Contributor

/test all

3 similar comments
@jamengual
Copy link
Contributor

/test all

@jamengual
Copy link
Contributor

/test all

@jamengual
Copy link
Contributor

/test all

main.tf Outdated Show resolved Hide resolved
nitrocode
nitrocode previously approved these changes Mar 7, 2023
@nitrocode nitrocode dismissed goruha’s stale review March 7, 2023 14:10

addressed feedback

@nitrocode nitrocode enabled auto-merge (squash) March 7, 2023 14:10
@nitrocode
Copy link
Member

/test all

@ngoyal16
Copy link
Contributor Author

ngoyal16 commented Mar 9, 2023

@goruha or @jamengual can you please retest?

@joe-niland
Copy link
Sponsor Member

/test terratest

@joe-niland
Copy link
Sponsor Member

@ngoyal16 the VPC limit issue still needs to be addressed

@Nuru
Copy link
Sponsor Contributor

Nuru commented Mar 9, 2023

/test terratest

@Nuru
Copy link
Sponsor Contributor

Nuru commented Mar 9, 2023

/test all

@Nuru
Copy link
Sponsor Contributor

Nuru commented Mar 9, 2023

/test all

@Nuru
Copy link
Sponsor Contributor

Nuru commented Mar 9, 2023

/test all

@Nuru
Copy link
Sponsor Contributor

Nuru commented Mar 10, 2023

/test all

Copy link
Sponsor Contributor

@Nuru Nuru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restoring @nitrocode's stale approval

@nitrocode nitrocode merged commit 2235dea into cloudposse:master Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants