Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serverlessv2 config to aws_rds_cluster.secondary #181

Merged
merged 2 commits into from Dec 5, 2023

Conversation

asmithdt
Copy link
Contributor

@asmithdt asmithdt commented Oct 9, 2023

what

Add missing config to aws_rds_cluster.secondary

why

Error: creating RDS Cluster (<redacted>) Instance (<redacted>): InvalidDBClusterStateFault: Set the Serverless v2 scaling configuration on the parent DB cluster before creating a Serverless v2 DB instance.
│       status code: 400, request id:

Tested on my cluster and confirmed to work when a serverless configuration is provided.

@asmithdt asmithdt requested review from a team as code owners October 9, 2023 16:10
@milldr
Copy link
Sponsor Member

milldr commented Nov 15, 2023

/terratest

@asmithdt
Copy link
Contributor Author

Failure is not to do with my change - did you want me to fix anyway? Looks like a mismatch between available versions and selected family

@milldr
Copy link
Sponsor Member

milldr commented Nov 16, 2023

Failure is not to do with my change - did you want me to fix anyway? Looks like a mismatch between available versions and selected family

Yes unfortunately we need to resolve those errors before merging this PR. If you don't mind fixing that would be great! Otherwise, we'll fix the tests outside this PR whenever we have time, but it might be awhile before we have availability.

Also, you will likely need to rebuild the README for the ci checks to pass. For example, #182

make init
make readme

@asmithdt
Copy link
Contributor Author

asmithdt commented Dec 1, 2023

Failure is not to do with my change - did you want me to fix anyway? Looks like a mismatch between available versions and selected family

Yes unfortunately we need to resolve those errors before merging this PR. If you don't mind fixing that would be great! Otherwise, we'll fix the tests outside this PR whenever we have time, but it might be awhile before we have availability.

Also, you will likely need to rebuild the README for the ci checks to pass. For example, #182

make init
make readme

Sorry for the delay! Have updated to what I think should work

@milldr
Copy link
Sponsor Member

milldr commented Dec 5, 2023

/terratest

Copy link
Sponsor Member

@milldr milldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution and for fixing the tests 🚀

@milldr milldr merged commit 850d59b into cloudposse:main Dec 5, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants