Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to TF_DATA_DIR retained by mistake in #40 #181

Merged
merged 1 commit into from
May 15, 2023
Merged

Remove reference to TF_DATA_DIR retained by mistake in #40 #181

merged 1 commit into from
May 15, 2023

Conversation

Nuru
Copy link
Sponsor Contributor

@Nuru Nuru commented May 11, 2023

what

why

  • Added by mistake, has potential for abuse or innocent misuse to cause big problems

@Nuru Nuru added the no-release Do not create a new release (wait for additional code changes) label May 11, 2023
@Nuru Nuru requested a review from aknysh May 11, 2023 19:19
@Nuru Nuru requested a review from a team as a code owner May 11, 2023 19:19
@Nuru Nuru mentioned this pull request May 11, 2023
Closed
@Nuru
Copy link
Sponsor Contributor Author

Nuru commented May 11, 2023

/test all

@Nuru Nuru enabled auto-merge (squash) May 11, 2023 19:27
Gowiem
Gowiem approved these changes May 15, 2023
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Nuru Nuru merged commit a8d63f9 into master May 15, 2023
6 checks passed
@Nuru Nuru deleted the Nuru-patch-1 branch May 15, 2023 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nuru @Gowiem