Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed ACL #88

Closed
wants to merge 4 commits into from
Closed

Changed ACL #88

wants to merge 4 commits into from

Conversation

JohnShortland
Copy link

what

  • Removes bucket ACL from s3_bucket resource
  • Adds public access block resource
  • Adds object ownership control resource

why

  • Module no longer works

references

closes #84

@JohnShortland JohnShortland requested review from a team as code owners May 24, 2023 13:14
@JohnShortland JohnShortland requested review from jamengual and woz5999 and removed request for a team May 24, 2023 13:14
@JohnShortland
Copy link
Author

@woz5999 @jamengual Can I get a review on this when you guys have a chance?

@joe-niland joe-niland added the patch A minor, backward compatible change label Jul 6, 2023
@joe-niland
Copy link
Sponsor Member

Hey @JohnShortland i'm looking into what's up with the checks

@JohnShortland
Copy link
Author

Hey @JohnShortland i'm looking into what's up with the checks

Sounds good, re-ran the readme steps but no changes this time.

@milldr milldr mentioned this pull request Jul 24, 2023
Merged
@Nuru Nuru closed this in #93 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

@woz5999 woz5999 Awaiting requested review from woz5999 woz5999 is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
patch A minor, backward compatible change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changes to default S3 settings cause module to fail
2 participants
@JohnShortland @joe-niland