Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rework value mapping for for_each and update dependencies #11

Merged
merged 5 commits into from
May 14, 2021

Conversation

SweetOps
Copy link
Contributor

@SweetOps SweetOps commented Feb 25, 2021

what

  • rework value mapping for for_each
  • bump minimal required version of TF to 0.14.0
  • bump terratest to v0.32.8

why

  • terraform has weird limitation which blocks using of dynamic values inside the for_each loop
The "for_each" value depends on resource attributes that cannot be determined
until apply, so Terraform cannot predict how many instances will be created.
To work around this, use the -target argument to first apply only the
resources that the for_each depends on.

@SweetOps SweetOps requested review from a team as code owners February 25, 2021 14:08
@SweetOps
Copy link
Contributor Author

/test all

@SweetOps SweetOps requested a review from a team as a code owner February 25, 2021 14:24
@SweetOps
Copy link
Contributor Author

/test all

@SweetOps
Copy link
Contributor Author

/test terratest

@SweetOps SweetOps changed the title refactor: rework value mapping for for_each refactor: rework value mapping for for_each and update dependencies Feb 25, 2021
@SweetOps
Copy link
Contributor Author

/test bats

@SweetOps
Copy link
Contributor Author

/test readme

osterman
osterman previously approved these changes May 10, 2021
@mergify
Copy link

mergify bot commented May 12, 2021

This pull request is now in conflict. Could you fix it @SweetOps? 🙏

@SweetOps
Copy link
Contributor Author

/test all

@SweetOps SweetOps merged commit 1344493 into master May 14, 2021
@SweetOps SweetOps deleted the CPCO-409_2 branch May 14, 2021 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants