Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module cleanup #4

Merged
merged 5 commits into from
Nov 17, 2020
Merged

module cleanup #4

merged 5 commits into from
Nov 17, 2020

Conversation

mcalhoun
Copy link
Member

@mcalhoun mcalhoun commented Nov 13, 2020 •
edited
Loading

what

  • add a missing iam policy that allows eventbridge to publish to sns.
  • update to latest terratest version.
  • cleanup some docs and headers

why

  • Without the IAM policy, AWS EventBridge isn't able to publish findings to AWS Simple Notification Services (SNS)

@mcalhoun mcalhoun requested review from a team as code owners November 13, 2020 23:02
@mcalhoun
Copy link
Member Author

/test all

@mcalhoun mcalhoun added the terraform/0.13 Module requires Terraform 0.13 or later label Nov 15, 2020
@mcalhoun
Copy link
Member Author

/test all

@mcalhoun mcalhoun merged commit 20c1106 into master Nov 17, 2020
@mcalhoun mcalhoun deleted the chore/module-cleanup branch November 17, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@adamcrews adamcrews Awaiting requested review from adamcrews

@woz5999 woz5999 Awaiting requested review from woz5999

Assignees
No one assigned
Labels
terraform/0.13 Module requires Terraform 0.13 or later
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mcalhoun @osterman