Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the VPC params to the call of the notify_slack module #45

Merged
merged 3 commits into from Jan 2, 2024
Merged

Added the VPC params to the call of the notify_slack module #45

merged 3 commits into from Jan 2, 2024

Conversation

boris-dyga-SM
Copy link
Contributor

what

  • Added VPC params to be able to deploy the Lambda inside VPC as well

why

  • PCI DSS requires any Lambda to be deployed inside a VPC

references

@boris-dyga-SM boris-dyga-SM requested review from a team as code owners January 1, 2024 10:24
@boris-dyga-SM
Copy link
Contributor Author

/terratest

@boris-dyga-SM
Copy link
Contributor Author

/terratest

@johncblandii
Copy link

/test all

@johncblandii
Copy link

/terratest

@aknysh aknysh merged commit a338e94 into cloudposse:main Jan 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@boris-dyga-SM @johncblandii @aknysh