Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify KMS key to enable Server-Side Encryption #20

Merged
merged 3 commits into from
Sep 22, 2020
Merged

Specify KMS key to enable Server-Side Encryption #20

merged 3 commits into from
Sep 22, 2020

Conversation

chrispblink
Copy link
Contributor

@chrispblink chrispblink commented Sep 22, 2020 •
edited
Loading

what

  • A variable has been added to allow users to specify a KMS key ARN for Server-Side Encryption
  • This variable defaults to null making it optional

why

  • A common use case for SNS messages is processing sensitive data (ex: PII, PHI, payment card)
  • Many vendors and government regulators will require end-to-end encryption of this sensitive data

references

Ikana
Ikana previously approved these changes Sep 22, 2020
View reviewed changes
@aknysh
Copy link
Member

aknysh commented Sep 22, 2020

/rebuild-readme

@aknysh
Copy link
Member

aknysh commented Sep 22, 2020

/terraform-fmt

1 similar comment
@aknysh
Copy link
Member

aknysh commented Sep 22, 2020

/terraform-fmt

@aknysh
Copy link
Member

aknysh commented Sep 22, 2020

@chrispblink please rebase

@chrispblink chrispblink requested review from a team as code owners September 22, 2020 19:27
@aknysh
Copy link
Member

aknysh commented Sep 22, 2020

/rebuild-readme

@aknysh
Copy link
Member

aknysh commented Sep 22, 2020

/test all

aknysh
aknysh approved these changes Sep 22, 2020
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @chrispblink

@aknysh aknysh merged commit 45dcaeb into cloudposse:master Sep 22, 2020
@jesse-osiecki jesse-osiecki mentioned this pull request Jul 7, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh approved these changes

@Ikana Ikana Ikana left review comments

@Makeshift Makeshift Awaiting requested review from Makeshift

@joe-niland joe-niland Awaiting requested review from joe-niland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable encryption in resource aws_sns_topic
3 participants
@chrispblink @aknysh @Ikana