Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add overwrite argument back #53

Merged
merged 3 commits into from
Feb 5, 2024
Merged

chore: add overwrite argument back #53

merged 3 commits into from
Feb 5, 2024

Conversation

gberenice
Copy link
Contributor

@gberenice gberenice commented Jan 31, 2024 •
edited
Loading

what

  • Unfortunately, we have to add the overwrite argument back due to the confusion of its deprecation:

Lastly, and unfortunately, configurations expecting the standard update flow will need to keep overwrite = true set until this becomes the default behavior in v6.0.0. Removing it in v5.X will result in the default value of false, preventing the parameter value from being updated, causing persistent differences.

why

  • Prevent undesired behaviour.

references

@gberenice gberenice requested review from a team as code owners January 31, 2024 16:46
@gberenice gberenice requested review from kevcube and florian0410 and removed request for a team January 31, 2024 16:46
kevcube
kevcube previously approved these changes Jan 31, 2024
View reviewed changes
@kevcube
Copy link
Contributor

kevcube commented Feb 1, 2024

/terratest

@kevcube
Copy link
Contributor

kevcube commented Feb 5, 2024

/terratest

@kevcube
Copy link
Contributor

kevcube commented Feb 5, 2024

/terratest

@kevcube kevcube enabled auto-merge (squash) February 5, 2024 10:34
kevcube
kevcube approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@kevcube kevcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @gberenice shipping!

@kevcube kevcube merged commit cd25893 into cloudposse:main Feb 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevcube kevcube kevcube approved these changes

@florian0410 florian0410 Awaiting requested review from florian0410 florian0410 is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gberenice @kevcube